-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unify data IDs #594
feat: unify data IDs #594
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice. Does break loading old session files with layers due to the dropping of the gross image/dicom prefix on the layer IDs. But I'm OK with that.
Volume keys are now used as image data IDs. This simplifies going back and forth between the image and dicom store, and simplifies the structure of the selection object to be just an ID string.
We can figure out a migration layer later if this becomes a major issue. For now, I've bumped the manifest major version. |
When/if we get a complaint, we have some migrate code here: VolView/src/io/import/processors/restoreStateFile.ts Lines 114 to 162 in a7b6290
|
Volume keys are now used as image data IDs. This simplifies going back and forth between the image and dicom store, and simplifies the structure of the selection object to be just an ID string.
This doesn't address migration of older session files. That is a nice-to-have, but we don't have a good way of handling migrations at the moment. @PaulHax if this breaks stored session files, then I'll add a migration path.