Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ControlStrip): Moved menu button to ControlStrip #605

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

lchauvin
Copy link
Contributor

@lchauvin lchauvin commented Jun 7, 2024

Related to #604

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 93a0e02
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6672f0d9ca3a530008731306
😎 Deploy Preview https://deploy-preview-605--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst
Copy link
Collaborator

floryst commented Jun 18, 2024

@PaulHax what do you think of the placement? The alternative would be to remove the v-if="mobile" and have the button showing on the left of the logo.

@PaulHax
Copy link
Collaborator

PaulHax commented Jun 18, 2024

Left of logo would look good to. Strangely I don't have a strong opinion =) Just a slight unease about the "connection" between the button and the drawer, but no obvious solution. Overall I think this is a nice upgrade.

@lchauvin
Copy link
Contributor Author

lchauvin commented Jun 18, 2024

I decided to put it there, because initially it was left of the logo, but I didn't see it immediately, and I thought it would open another menu. I thought putting on the menu, so you can't miss it.

@floryst
Copy link
Collaborator

floryst commented Jun 18, 2024

Try reverting your changes and drop the v-if="mobile" attr to show the menu button unconditionally and let me know what you think. I agree that there is some tenuous connection with the positioning of the menu button in the control strip, and it might work better to the left of the logo. Would be good to get your opinion on it.

@lchauvin
Copy link
Contributor Author

I could put it next to the logo if you think it's better. However, like I said, it was initially there, but it wasn't directly clear to me what was this button for, maybe because of the logo right next to it, I'm not sure. I felt like it was gonna open another dropdown menu or something like that.

@floryst
Copy link
Collaborator

floryst commented Jun 26, 2024

I think this is consistent with how some existing designs operate. The material design website and vuetify's website both use the triple bar icon around the logo to toggle the sidebar visibility on smaller screens. In this case, we are just enabling that functionality regardless of screen size.

@floryst floryst added this pull request to the merge queue Jun 27, 2024
Merged via the queue into Kitware:main with commit 53950c0 Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants