feat(Slice): Use keyboard to change slices of the active view #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulHax
reviewed
Dec 12, 2024
Comment on lines
+42
to
+56
| const nextSlice = () => () => { | ||
| const { currentImageID } = useCurrentImage(); | ||
| const { activeViewID } = useViewStore(); | ||
|
|
||
| const { slice: currentSlice } = useSliceConfig(activeViewID, currentImageID); | ||
| currentSlice.value += 1; | ||
| }; | ||
|
|
||
| const previousSlice = () => () => { | ||
| const { currentImageID } = useCurrentImage(); | ||
| const { activeViewID } = useViewStore(); | ||
|
|
||
| const { slice: currentSlice } = useSliceConfig(activeViewID, currentImageID); | ||
| currentSlice.value -= 1; | ||
| }; |
There was a problem hiding this comment.
To remove duplicate code, could define something like offsetSlice(offset: number) then
const nextSlice = () => offsetSlice(1)
const previousSlice = () => offsetSlice(-1)
| @@ -28,6 +29,13 @@ import { useViewStore } from '../store/views'; | |||
|
|
|||
| export default defineComponent({ | |||
| name: 'LayoutGrid', | |||
| methods: { | |||
| onFocusView(id: string, type: string) { | |||
There was a problem hiding this comment.
👍️ Good
Also, when I scroll with mouse wheel on a view, then press the arrow keys, its not always the same view that gets its slice changed. So maybe setActiveView on scroll events too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs this PR to be merged first: #676