Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Users Annotating Recordings #28

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Multiple Users Annotating Recordings #28

merged 8 commits into from
Feb 1, 2024

Conversation

BryonLewis
Copy link
Collaborator

@BryonLewis BryonLewis commented Jan 30, 2024

resolves #25

This PR is intended to allow other users on the system to annotated and make annotations on other's recordings.
To do this there is now an option when uploading (and can also be edited) called public. This allows others to see the recording and create annotations on it.

Done:

  • Added the public field and created a migration for it in the recordings
  • Updated the POST and added a PATCH to set Public state on Recordings
  • The Main Recording view now has your own annotations plus annotations that are shared with you.
  • You can see the number of distinct users that have made annotations on your own recordings.
  • You can also see if you made annotations on a shared recording.
  • When returning spectrogram data back with annotations it will also include the list of users who have made annotations on your recording
  • Included a currentUser response for the specotrgram, this is used for styling of annotations in the list
  • Updated the LayerManager and layers to have otherUserAnnotations which is a dictionary of annotations by other users which can be added to the current view.
  • Other User Annotations only show up on your own recordings, you can't see other's annotations for their recordings.
  • Imported D3 to create an ordinal color system for the usernames, but eliminates the red/yellow/cyan for the default colors.
  • Prevent editing of other user's annotations (you can't even select them)
BatsSharing.mp4

@BryonLewis BryonLewis marked this pull request as ready for review February 1, 2024 13:12
@BryonLewis BryonLewis merged commit e90e806 into main Feb 1, 2024
6 checks passed
@BryonLewis BryonLewis deleted the share-recordings branch February 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm workflow for multiple users.
1 participant