feat(girder): allow disabling girder integration entirely #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lgt2x
force-pushed
the
disable-girder-option
branch
from
e5e3007 to
a42a8e2
Compare
|
@bourdaisj @floryst could anyone review please ? :) |
|
LGTM! |
|
lgtm |
|
🎉 This PR is included in version 4.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks for the merge & tag! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when exporting a scene to Glance from ParaView, I want to be able to make the HTML file be isolated from the network, and avoid making any network call to external servers. This patch allows disabling the Girder integration entierly when the
noGirderURL parameter is set. On ParaView's side, if a checkbox is active when creating the Glance export, the URL parameternoGirderwill be forced onto the page if it is not set.Please tell me if you see a better implementation of this idea.
cc @mwestphal