Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: produce an inline + regular bundle #503

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: produce an inline + regular bundle #503

merged 1 commit into from
Aug 7, 2024

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Aug 6, 2024

@bruyeret I realized that we do have references to ParaViewGlance.html in the output bundle, so this PR adds that back while preserving the regular bundle.

@bourdaisj
Copy link
Contributor

@Lgt2x

@Lgt2x
Copy link
Contributor

Lgt2x commented Aug 7, 2024

When I run both build commands in a row locally, ParaViewGlance.html is removed when running build:release. A possible solution would be moving ParaViewGlance.html outside of dist after the first build, run the second one and move ParaViewGlance.html to dist again

@Lgt2x
Copy link
Contributor

Lgt2x commented Aug 7, 2024

When I run both build commands in a row locally, ParaViewGlance.html is removed when running build:release. A possible solution would be moving ParaViewGlance.html outside of dist after the first build, run the second one and move ParaViewGlance.html to dist again

Oh just noticed you changed cleanOnceBeforeBuildPatterns. All good then

@floryst floryst merged commit da8426e into master Aug 7, 2024
3 checks passed
@floryst floryst deleted the output-inline branch August 7, 2024 14:16
Copy link

github-actions bot commented Aug 7, 2024

🎉 This PR is included in version 4.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants