Vital mesh vertex_array has inconsistent dimension template #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mesh.h's
mesh_vertex_array<d>claims to be an array of vertices of dimensiond, however the typedef for the internal vertex representationvert_tis hardcoded to have a dimension of3.It seems to me that the internal representation should either reflect the description provided in the doc comments, or the template should be removed entirely. I can only find one use case where
mesh_vertex_array<d>is used with ad != 3here, and the fact thatd = 2has no effect on the usage.