Fix VIDL FFmpeg Build Issues #1708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-riehm
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
I've added a commit to use the more recent klv_demuxer interface and avoid putting vxl things in a different arrow. While I believe the changes after that commit should "work", this is a band-aid on top of a band-aid on top of unmaintained code. Hopefully we can deprecate and remove the VIDL reader in favor of the ffmpeg arrow at some point.
(Also, if you're fine with the commit I pushed, the commits should be squashed to get rid of the ghostflow error)
|
Agree on eventually deprecation, I don't use klv parsing here just the reader for the time being (so just need it to build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.