Add ability to export transformed dataset #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesgenova
force-pushed
the
export-dataset
branch
2 times, most recently
from
919dcdf to
de9864c
Compare
alesgenova
force-pushed
the
export-dataset
branch
from
de9864c to
247a556
Compare
PaulHax
approved these changes
Dec 19, 2024
| @@ -58,11 +81,21 @@ def __init__(self, server=None): | |||
| ) | |||
|
|
|||
| known_args, _ = self.server.cli.parse_known_args() | |||
| dataset_identifiers = expand_hugging_face_datasets( | |||
|
|
|||
| self.state.input_datasets = expand_hugging_face_datasets( | |||
There was a problem hiding this comment.
is input_datasets displayed by the GUI?
Comment on lines
+33
to
+34
| self.context.setdefault("repository", "") | ||
| self.state.setdefault("current_dataset", "") |
There was a problem hiding this comment.
This is set in core.py too. Should we refactor so we initialize the shared setup in once place?
Comment on lines
+43
to
+45
| def on_server_ready(self, *args, **kwargs): | ||
| # Bind instance methods to state change | ||
| pass |
Comment on lines
+51
to
+52
| if self._exporting_dataset(): | ||
| return |
There was a problem hiding this comment.
User could have stale images in the export if they change transforms, then click export again?
| new_instance.set_parameters(instance.get_parameters()) | ||
| transforms.append(new_instance) | ||
|
|
||
| # transforms = list(map(lambda t: t["instance"], self.context.transforms)) |
| Path.mkdir(destination_dir, parents=True) | ||
|
|
||
| img = dataset.get_image(image_id) | ||
| img.load() # Avoid OSError(24, 'Too many open files') |
There was a problem hiding this comment.
proably not needed in this loop?
| return props.status === 'pending' | ||
| }) | ||
|
|
||
| const barColor = computed(() => { |
There was a problem hiding this comment.
Message text may help too, as I only get red and not sure if that is normal.
| self.form_ui() | ||
|
|
||
| def form_ui(self): | ||
| with html.Div(trame_server=self.server): |
There was a problem hiding this comment.
Is trame_server kwarg needed?
| /> | ||
| <div class="q-gutter-sm"> | ||
| <q-radio v-model="fullExport" :val="true" :disable="exporting" label="Full" /> | ||
| <q-radio v-model="fullExport" :val="false" :disable="exporting" label="Selection" /> |
There was a problem hiding this comment.
Suggested change
| <q-radio v-model="fullExport" :val="false" :disable="exporting" label="Selection" /> | |
| <q-radio v-model="fullExport" :val="false" :disable="exporting" label="Sampled" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #126