Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddings: remove batch size parameter and default to 2D #174

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jan 17, 2025

App should figure out batch size automatically by
catching out of memory errors.

It is easier to see image relationships in 2D plot.

  • Show origin axis in 2D mode

@PaulHax PaulHax changed the title feat(embeddings): remove batch size parameter embeddings: remove batch size parameter and deault to 2D Jan 17, 2025
@PaulHax PaulHax changed the title embeddings: remove batch size parameter and deault to 2D embeddings: remove batch size parameter and default to 2D Jan 17, 2025
@PaulHax PaulHax marked this pull request as ready for review January 17, 2025 18:35
@PaulHax PaulHax force-pushed the simplify-embedding-params branch from 0d33561 to a9056b0 Compare January 20, 2025 15:27
@PaulHax PaulHax requested a review from alesgenova January 20, 2025 20:16
Copy link
Member

@alesgenova alesgenova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor thing is the warning given by the linter in ScatterPlot.vue

@PaulHax PaulHax force-pushed the simplify-embedding-params branch from a9056b0 to 3710262 Compare January 20, 2025 21:30
@PaulHax PaulHax force-pushed the simplify-embedding-params branch from 3710262 to 61f7d3b Compare January 20, 2025 23:18
@PaulHax PaulHax force-pushed the simplify-embedding-params branch 5 times, most recently from 55d08c1 to 0b65692 Compare January 21, 2025 19:44
@PaulHax PaulHax force-pushed the embedding-fix branch 2 times, most recently from b96b9e2 to b568834 Compare January 21, 2025 19:54
Base automatically changed from embedding-fix to main January 21, 2025 19:54
@PaulHax PaulHax force-pushed the simplify-embedding-params branch from 0b65692 to 5e5f818 Compare January 21, 2025 19:55
@PaulHax PaulHax merged commit 82dbb35 into main Jan 21, 2025
11 of 12 checks passed
@PaulHax PaulHax deleted the simplify-embedding-params branch January 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants