Update examples #141
Update examples #141
Conversation
|
I don't think you want to trigger a new PyPI release of pan3d for examples/docs update. You should use a commit message like |
johnkit
force-pushed
the
update-examples
branch
2 times, most recently
from
0dcfff7 to
fe2a90d
Compare
|
Hacked in a commit to detect binder and hard-code local/vtkjs rendering. Good enough enable notebooks to work in binder. I didn't use the |
pan3d/viewers/preview.py
Outdated
| @@ -85,9 +86,11 @@ def __init__(self, server=None, local_rendering=None): | |||
| ) | |||
| args, _ = self.server.cli.parse_known_args() | |||
| self.local_rendering = local_rendering | |||
| if args.wasm: | |||
| if os.environ.get("BINDER_REQUEST") is not None: | |||
| self.local_rendering = "vtkjs" | |||
There was a problem hiding this comment.
why do you want to use vtkjs instead of wasm for binder?
There was a problem hiding this comment.
On my first test w/WASM (before I added this commit, I used the local_rendering argument), the renderwindow didn't display. Definitely possible I overlooked something, so I'll change to wasm and retest.
There was a problem hiding this comment.
So "vtkjs" is ok but "wasm" isn't. It looks like part or all of trame_vtklocal isn't getting installed, or is installed in the wrong place. I'll paste the js console messages below, but basically Jupyter aborts because it does not find __trame_vtklocal/js/style.css.
index-de5ee105.js:1
GET https://hub.binder.opensci.2i2c.cloud/user/kitware-pan3d-irtfxelw/trame-jupyter-server/servers/esgf-viewer/__trame_vtklocal/js/style.css net::ERR_ABORTED 404 (Not Found)
(anonymous) @ index-de5ee105.js:1
mo @ index-de5ee105.js:1
Ce @ index-de5ee105.js:1
So @ index-de5ee105.js:1
Fs @ index-de5ee105.js:23
await in Fs
(anonymous) @ index-de5ee105.js:23
index-de5ee105.js:23 Uncaught (in promise) Event {isTrusted: true, type: 'error', target: link, currentTarget: null, eventPhase: 0, …}
Fs @ index-de5ee105.js:23
await in Fs
(anonymous) @ index-de5ee105.js:23
There was a problem hiding this comment.
Do we want os.environ.get("BINDER_REQUEST") to superseed user input for local rendering request?
There was a problem hiding this comment.
I think I know why wasm could be missing in the install.
Let's add vtklocal.initialize(self.server) somewhere since the widget get conditionally instantiated.
johnkit
force-pushed
the
update-examples
branch
2 times, most recently
from
da51ac5 to
b84e6d7
Compare
|
I think the 2 pending changes are:
|
Also fix typo in esgf notebook
johnkit
force-pushed
the
update-examples
branch
from
b84e6d7 to
12ab9c4
Compare
Update pangeo and esgf examples to use latest config syntax and add some markdown cells
Pangeo Example
ESGF Example
