Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy lists #22

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

Jo-Byr
Copy link
Contributor

@Jo-Byr Jo-Byr commented Dec 17, 2024

Support proxy lists in the same way as string/number lists

@Jo-Byr Jo-Byr force-pushed the support-proxy-list branch from 6d4ebdb to 00d39c6 Compare December 17, 2024 14:45
@jourdain
Copy link
Collaborator

You need to format your commit appropriately so that semantic release can trigger a new release, update the change log and tag it on github for you.

@jourdain
Copy link
Collaborator

Looks reasonable otherwise.

@Jo-Byr Jo-Byr requested a review from bourdaisj December 17, 2024 15:35
@jourdain
Copy link
Collaborator

Please rework/reword your commit for semantic release

@Jo-Byr Jo-Byr force-pushed the support-proxy-list branch from 0b0c9a0 to 38a0533 Compare December 18, 2024 09:08
@bourdaisj
Copy link
Contributor

@Jo-Byr can you add an example?
Also your change introduces a difference between the vue2/vue3 implementation. can you add a markdown file in the docs folder to quickly explain the difference between the two implementations? something like vue2_vs_vue3 or else

@Jo-Byr
Copy link
Contributor Author

Jo-Byr commented Dec 18, 2024

your change introduces a difference between the vue2/vue3 implementation. can you add a markdown file in the docs folder to quickly explain the difference between the two implementations? something like vue2_vs_vue3 or else

I only implemented the proxy list support in the vue2 part of trame-simput. Maybe should I convert this PR to a draft PR for the time being and once the vue2 changes are validated I can add them to the vue3 part ?

@jourdain
Copy link
Collaborator

Should we merge?

Copy link
Contributor

@bourdaisj bourdaisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@jourdain jourdain merged commit 777badb into Kitware:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants