feat: setSize triggers WindowResizeEvent

Kitware · Oct 26, 2023 · 1435f51 · 1435f51
1 parent fae07e4
commit 1435f51
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/Sources/Rendering/OpenGL/RenderWindow/index.js b/Sources/Rendering/OpenGL/RenderWindow/index.js
@@ -1308,6 +1308,15 @@ function vtkOpenGLRenderWindow(publicAPI, model) {
     model.activeFramebuffer = newActiveFramebuffer;
   };
 
+  const superSetSize = publicAPI.setSize;
+  publicAPI.setSize = (width, height) => {
+    const modified = superSetSize(width, height);
+    if (modified) {
+      publicAPI.invokeWindowResizeEvent({ width, height });
+    }
+    return modified;
+  };
+
   publicAPI.getGraphicsResourceForObject = (vtkObj) => {
     if (!vtkObj) {
       return null;
@@ -1360,12 +1369,6 @@ function vtkOpenGLRenderWindow(publicAPI, model) {
       glRen?.releaseGraphicsResources();
     });
   };
-
-  model._onSizeChanged = (_publicAPI, _model, newValue) =>
-    publicAPI.invokeWindowResizeEvent({
-      width: newValue[0],
-      height: newValue[1],
-    });
 }
 
 // ----------------------------------------------------------------------------

diff --git a/Sources/Rendering/WebGPU/RenderWindow/index.js b/Sources/Rendering/WebGPU/RenderWindow/index.js
@@ -543,12 +543,16 @@ function vtkWebGPURenderWindow(publicAPI, model) {
     return ret;
   };
 
+  const superSetSize = publicAPI.setSize;
+  publicAPI.setSize = (width, height) => {
+    const modified = superSetSize(width, height);
+    if (modified) {
+      publicAPI.invokeWindowResizeEvent({ width, height });
+    }
+    return modified;
+  };
+
   publicAPI.delete = macro.chain(publicAPI.delete, publicAPI.setViewStream);
-  model._onSizeChanged = (_publicAPI, _model, newValue) =>
-    publicAPI.invokeWindowResizeEvent({
-      width: newValue[0],
-      height: newValue[1],
-    });
 }
 
 // ----------------------------------------------------------------------------