refactor: early return

Kitware · Jan 30, 2024 · ef07f27 · ef07f27
1 parent 14ae557
commit ef07f27
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/Sources/Widgets/Manipulators/LineManipulator/index.js b/Sources/Widgets/Manipulators/LineManipulator/index.js
@@ -12,14 +12,6 @@ export function projectDisplayToLine(
   renderer,
   glRenderWindow
 ) {
-  const near = glRenderWindow.displayToWorld(x, y, 0, renderer);
-  const far = glRenderWindow.displayToWorld(x, y, 1, renderer);
-  const viewDir = [0, 0, 0];
-  vtkMath.subtract(far, near, viewDir);
-
-  const normal = [0, 0, 0];
-  vtkMath.cross(lineDirection, viewDir, normal);
-  vtkMath.cross(normal, viewDir, normal);
   // if the active camera viewPlaneNormal and line direction are parallel, no change is allowed
   const dotProduct = Math.abs(
     vtkMath.dot(renderer.getActiveCamera().getViewPlaneNormal(), lineDirection)
@@ -28,6 +20,14 @@ export function projectDisplayToLine(
   if (1 - dotProduct < EPSILON) {
     return [];
   }
+  const near = glRenderWindow.displayToWorld(x, y, 0, renderer);
+  const far = glRenderWindow.displayToWorld(x, y, 1, renderer);
+  const viewDir = [0, 0, 0];
+  vtkMath.subtract(far, near, viewDir);
+
+  const normal = [0, 0, 0];
+  vtkMath.cross(lineDirection, viewDir, normal);
+  vtkMath.cross(normal, viewDir, normal);
 
   const numerator = vtkMath.dot(
     [near[0] - lineOrigin[0], near[1] - lineOrigin[1], near[2] - lineOrigin[2]],