Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple configuration error #2934

Closed
wants to merge 1 commit into from
Closed

Fix multiple configuration error #2934

wants to merge 1 commit into from

Conversation

rodrigobasilio2022
Copy link
Contributor

@rodrigobasilio2022 rodrigobasilio2022 commented Oct 14, 2023 •
edited
Loading

Context

This PR aims to fix the problem occuring when both options z-Buffer and Image Outline are configured. As this two options declare the same variable names when activated, it gives error in shader compilation

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: 27.3.1
    • OS: Windows 10
    • Browser: Chrome 117.0.5938.152

@floryst floryst requested a review from sankhesh October 18, 2023 14:56
@floryst
Copy link
Collaborator

floryst commented Oct 18, 2023

LGTM

@floryst
Copy link
Collaborator

floryst commented Oct 23, 2023

Can you rebase and squash your commits into a single refactor(.... commit?

@rodrigobasilio2022
Copy link
Contributor Author

Changed to #2940

@rodrigobasilio2022
Copy link
Contributor Author

rodrigobasilio2022 commented Oct 23, 2023 via email

@floryst floryst force-pushed the fix/multipleConfigurationError branch 2 times, most recently from 5c46d83 to c77bcd9 Compare October 23, 2023 18:08
@floryst
Copy link
Collaborator

floryst commented Oct 23, 2023

Closing this in favor of #2940

@floryst floryst closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sankhesh sankhesh Awaiting requested review from sankhesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigobasilio2022 @floryst