Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix itkwasmgeometry example #2958

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

bourdaisj
Copy link
Contributor

Context

Fix ITKHelper.
Improve ItkWasmGeometry example.
Improve vtkDataArray constructor

Results

Rendering of ItkWasmGeometry example is now correct.
fix #2853

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@bourdaisj bourdaisj requested a review from thewtex November 14, 2023 08:26
@bourdaisj bourdaisj self-assigned this Nov 14, 2023
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Julesdevops thank you!

@thewtex thewtex added this pull request to the merge queue Nov 14, 2023
Merged via the queue into Kitware:master with commit 3cc3abb Nov 14, 2023
3 checks passed
Copy link

🎉 This PR is included in version 29.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 14, 2023
@bourdaisj bourdaisj deleted the fix-itkwasmgeometry-example branch January 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Rendering issue when using ItkWasmGeometry
2 participants