Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript definitions #2976

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Add typescript definitions #2976

merged 1 commit into from
Jan 4, 2024

Conversation

bruyeret
Copy link
Contributor

@bruyeret bruyeret commented Jan 4, 2024

Main addition: ImageReslice typescript header

@bruyeret bruyeret requested a review from finetjul January 4, 2024 17:08
@finetjul finetjul added this pull request to the merge queue Jan 4, 2024
Merged via the queue into Kitware:master with commit 3cb0efd Jan 4, 2024
3 checks passed
@bruyeret bruyeret deleted the ts-headers branch January 5, 2024 09:28
@bruyeret
Copy link
Contributor Author

bruyeret commented Jan 5, 2024

This merge request did not trigger a release
From the logs of this action:
There are no relevant changes, so no new version is released.
I think that it is because my commit commit message starts with docs
How can I trigger a release anyway @floryst?

@floryst
Copy link
Collaborator

floryst commented Jan 5, 2024

docs() commit messages don't trigger a release. fix() is probably best for ts definition changes that need to be released.

The easiest solution is to wait for a merge that contains a release-able commit. I'm not familiar with manually cutting a release, though I suppose it could be possible.

Copy link

github-actions bot commented Jan 8, 2024

🎉 This PR is included in version 29.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jan 8, 2024
@floryst floryst mentioned this pull request Jan 10, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants