Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate example gallery #2977

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Conversation

finetjul
Copy link
Member

@finetjul finetjul commented Jan 4, 2024

Context

Further improve the example gallery.

Results

Entries in the example gallery are added.
Example documentation is improved.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows
    • Browser: Chrome

@finetjul finetjul force-pushed the populate-example-gallery branch 2 times, most recently from cac3e88 to 8008194 Compare January 5, 2024 00:09
@floryst
Copy link
Collaborator

floryst commented Jan 15, 2024

LGTM. There is a conflict with PLYWriterWithIcon.jpg that needs to be resolved.

…xamples

vtkFullScreenRenderWindow or vtkGenericRenderWindow must be used for simplicity

issue Kitware#2973
Reference HttpDataSetReader, HttpDataSetSeriesReader, HttpSceneLoader,
OfflineLocalView, ImageStream and RemoteView in the gallery.
Improve their documentation as well.

issue Kitware#2973
@finetjul finetjul force-pushed the populate-example-gallery branch from 8008194 to 5a34b5e Compare January 15, 2024 20:36
@floryst floryst added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Kitware:master with commit c2e9f2b Jan 23, 2024
3 checks passed
Copy link

🎉 This PR is included in version 29.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants