Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vtkpicker): update doc and typing #2985

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

bourdaisj
Copy link
Contributor

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@bourdaisj bourdaisj enabled auto-merge January 12, 2024 16:25
@bourdaisj bourdaisj added this pull request to the merge queue Jan 12, 2024
@finetjul finetjul requested a review from daker January 12, 2024 16:32
Merged via the queue into Kitware:master with commit 1411330 Jan 12, 2024
3 checks passed
* Set position in mapper coordinates of pick point.
* @param {Vector3} mapperPosition The mapper coordinates of pick point.
*/
setMapperPositionFrom(mapperPosition: Vector3): boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be removed, it's part of the methods
Capture d’écran du 2024-01-13 10-41-22

*/
getMapperPositionByReference(): number[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This methods should not be removed
Capture d’écran du 2024-01-13 10-44-04

@bourdaisj
Copy link
Contributor Author

Apologies guys @daker @finetjul , shouldn't have clicked merge.
I open another PR to fix this and check the typing of event related code: #2989

Copy link

🎉 This PR is included in version 29.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jan 15, 2024
@bourdaisj bourdaisj deleted the update-vtkpicker-doc branch January 24, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants