Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(imageviewer): add an ImageViewer example #2987

Merged
merged 1 commit into from
Jan 23, 2024
Merged

docs(imageviewer): add an ImageViewer example #2987

merged 1 commit into from
Jan 23, 2024

Conversation

finetjul
Copy link
Member

This can help with debugging.

Context

There is a GeometryViewer and a VolumeViewer, but no 2D ImageViewer

Results

Adds an ImageViewer.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows
    • Browser: Chrome

@finetjul
docs(imageviewer): add an ImageViewer example
6f6a4f3 
This can help with debugging.
@floryst
Copy link
Collaborator

floryst commented Jan 16, 2024

LGTM

@floryst floryst added this pull request to the merge queue Jan 23, 2024
Merged via the queue into Kitware:master with commit ebb07ac Jan 23, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 29.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finetjul @floryst