Drop tape catch #2995
Merged
Drop tape catch #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
approved these changes
Jan 22, 2024
|
🎉 This PR is included in version 29.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Drops tape-catch in favor of just using tape.
Probably related to failing tests in #2979.
This change means unhandled exceptions will terminate the test runner rather than resulting in a failed test. Since there are no tests that rely on unhandled exceptions to fail the test, this change doesn't affect anything.
In exchange, we get better handling of unhandled rejected promises. Tests can now be written with async/await and tape will fail a test if a test rejects with an error.
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting