Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CSS helper for CSS filters #3009

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

bruyeret
Copy link
Contributor

@bruyeret bruyeret commented Feb 1, 2024

Create utility functions to manipulate equivalent of filters in vtk.js.
Based on the W3C specification.

@bruyeret bruyeret requested a review from finetjul February 1, 2024 17:58
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test or an example for the CSS filters functions.
Otherwise it's hard to see how it can be reused.

Sources/Common/Core/Math/index.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
Sources/Rendering/Core/ColorTransferFunction/CssFilters.js Outdated Show resolved Hide resolved
@bruyeret bruyeret requested a review from finetjul February 8, 2024 15:55
@bruyeret bruyeret force-pushed the css-helper branch 2 times, most recently from 0276aa4 to 1cb6e29 Compare February 8, 2024 16:16
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Feb 8, 2024
Merged via the queue into Kitware:master with commit 6f62bc6 Feb 8, 2024
3 checks passed
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 29.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Feb 8, 2024
@bruyeret bruyeret deleted the css-helper branch February 14, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants