fix(reslicecursorwidget): fix camera reset on rotation after a camera… #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
force-pushed
the
rcw-fix-camera-reset-on-rotate-after-camera-translation
branch
from
b50d278 to
0e65ed8
Compare
|
@bruyeret could I have broken the CPR widget ? |
bruyeret
approved these changes
Mar 19, 2024
I tested and it doesn't look broken, I don't think that the change could affect it |
floryst
reviewed
Mar 19, 2024
|
LGTM |
5 tasks
|
Whenever this is ready to merge, we should merge it with #3020 to cut a single major release, instead of two. |
6 tasks
… translation When the user translates a camera (shift+left drag), and then rotate the reslice cursor widget in another view, the camera was reset. This is because the focal point offsets were not "stored" after the camera translation. The rotation was therefore resetting the camera translation. A solution would have been to observe the interactor style each time the camera is manipulated. Instead, we prefer to save the focal point offsets before any reslice cursor widget interaction happens, namely when startInteraction is triggered. This makes computeFocalPointOffset parameter in the reslice cursor widget interactionEvent obsolete. It has therefore been removed along with the associated canUpdateFocalPoint. This is not the behavior's responsibility to tell the event consumers what they must do. BREAKING CHANGE: ResliceCursorWidget.interactionEvent has been modified
finetjul
force-pushed
the
rcw-fix-camera-reset-on-rotate-after-camera-translation
branch
from
0e65ed8 to
a2ce9a9
Compare
|
🎉 This PR is included in version 30.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… translation
BREAKING CHANGE: ResliceCursorWidget.interactionEvent has been modified
Context
When the user translates a camera (shift+left drag), and then rotate the reslice cursor widget in another view, the camera was reset. This is because the focal point offsets were not "stored" after the camera translation. The rotation was therefore resetting the camera translation.
Results
A solution would have been to observe the interactor style each time the camera is manipulated. Instead, we prefer to save the focal point offsets before any reslice cursor widget interaction happens, namely when startInteraction is triggered.
Changes
This makes computeFocalPointOffset parameter in the reslice cursor widget interactionEvent obsolete. It has therefore been removed along with the associated canUpdateFocalPoint. This is not the behavior's responsibility to tell the event consumers what they must do.
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting