Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): opacity test for volume picking #3044

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(picker): opacity test for volume picking #3044

merged 1 commit into from
Mar 25, 2024

Conversation

bourdaisj
Copy link
Contributor

@bourdaisj bourdaisj commented Mar 25, 2024 •
edited
Loading

Context

latest changes on vtkPicker introduced regression on volume picking.

Results

fix VolumePicker example

Changes

fix testing for opacity + add test for vtkPicker usage with vtkVolume

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@bourdaisj bourdaisj requested a review from finetjul March 25, 2024 09:17
@bourdaisj bourdaisj self-assigned this Mar 25, 2024
finetjul
finetjul approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourdaisj bourdaisj added this pull request to the merge queue Mar 25, 2024
Merged via the queue into Kitware:master with commit 723c19a Mar 25, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 30.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees

@bourdaisj bourdaisj

Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bourdaisj @finetjul