Share GPU ressources across render windows #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory public API This method changed the static Map `CLASS_MAPPING` of the corresponding backend. It was only used by the API specific render windows. Replace its usage with what is done everywhere else.
scalarTextureString didn't have a purpose and prevented caching of GPU resources
A new feature will add the ability to use a render window as child of another render window This change prevents using a render window where a renderer is needed
bruyeret
force-pushed
the
share-textures
branch
3 times, most recently
from
f500ef1 to
823da53
Compare
finetjul
reviewed
Apr 5, 2024
bruyeret
force-pushed
the
share-textures
branch
2 times, most recently
from
7b2118a to
1d7dfe0
Compare
finetjul
reviewed
Apr 9, 2024
To share resources accross render windows, they need to share a common context To do so, the render windows can now have a parent that will contain the shared context The child render windows will proxy some methods of their parent to do the rendering The content of the parent canvas is then copied to the child canvas using a 2D context
|
The picking has been smoke tested and seems to be working fine. const mainCanvas = mainRenderWindowView.getCanvas();
mainCanvas.style.width = '500px';
document.body.appendChild(mainCanvas); |
|
@sankhesh can you please review when you get a chance |
|
🎉 This PR is included in version 30.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@bruyeret Sorry, I missed the review period but the changes look good to me. Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to share a single context for several render windows.
This enables GPU ressource sharing accross render windows.
This feature uses
drawImagefrom the main WebGL context to the child render window's canvas. It is slow if there are a lot of render windows on Firefox: see this issue.