Add vtk threshold point #3081
Open
Add vtk threshold point #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
commented
Jun 8, 2024
|
Are you planning on adding typescript definitions as well? |
I was not planning to because I do not use typescript. Shall we make it mandatory for new contributions ? |
It's a good idea to do so nowadays, especially since vtk.js is ingested by typescript projects. |
This filter can threshold points with PointData criteria or point coordinates.
finetjul
force-pushed
the
add-vtkThresholdPoint
branch
from
cea72ef to
74f6589
Compare
floryst
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add vtkThresholdPoints filter.
Results
A new filter with an example are added.
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting