Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(shapewidgetexample): fix ellipse coverage in oblique mode #3188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(shapewidgetexample): fix ellipse coverage in oblique mode #3188

wants to merge 1 commit into from

Conversation

finetjul
Copy link
Member

Context

In oblique mode, depending on the plane normal, the compute histogram function was not covering the entire ellipse.

Results

All the voxels in the ellipse are now covered.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows
    • Browser: Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finetjul @floryst