Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CanvasView): allow setting canvas element #3197

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix(CanvasView): allow setting canvas element #3197

merged 1 commit into from
Jan 1, 2025
+20 −6

Conversation

daker
Copy link
Collaborator

@daker daker commented Dec 25, 2024

Context

Allow setting the canvas element for RemoteView

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker force-pushed the remoteview-canvas branch from f87c27f to f758ffa Compare December 25, 2024 23:12
floryst
floryst approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @jourdain

@daker daker force-pushed the remoteview-canvas branch 2 times, most recently from 1fc265e to 53f78c8 Compare December 27, 2024 14:00
@daker daker force-pushed the remoteview-canvas branch from 53f78c8 to b145a0c Compare January 1, 2025 22:12
@jourdain jourdain added this pull request to the merge queue Jan 1, 2025
Merged via the queue into Kitware:master with commit 3c562c5 Jan 1, 2025
3 checks passed
@daker daker deleted the remoteview-canvas branch January 1, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul left review comments

@floryst floryst floryst approved these changes

@jourdain jourdain jourdain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daker @finetjul @jourdain @floryst