Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback voter #387

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add callback voter #387

merged 1 commit into from
Oct 18, 2023

Conversation

Florin1
Copy link
Contributor

@Florin1 Florin1 commented Oct 18, 2023

No description provided.

@Florin1 Florin1 force-pushed the add_callback_voter branch from d898257 to 84e02ff Compare October 18, 2023 15:08
@Florin1 Florin1 requested a review from stof October 18, 2023 15:08
@garak garak added the hacktoberfest-accepted https://hacktoberfest.digitalocean.com label Oct 18, 2023
Copy link
Collaborator

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry in the changelog for the feature (under a title 3.5 (unreleased))

tests/Knp/Menu/Tests/Matcher/Voter/CallbackVoterTest.php Outdated Show resolved Hide resolved
tests/Knp/Menu/Tests/Matcher/Voter/CallbackVoterTest.php Outdated Show resolved Hide resolved
tests/Knp/Menu/Tests/Matcher/Voter/CallbackVoterTest.php Outdated Show resolved Hide resolved
@Florin1 Florin1 force-pushed the add_callback_voter branch from 84e02ff to 6a87d8d Compare October 18, 2023 15:35
@Florin1 Florin1 force-pushed the add_callback_voter branch from 6a87d8d to 71f7e53 Compare October 18, 2023 16:00
@Florin1 Florin1 requested review from garak and stof October 18, 2023 16:01
@garak garak merged commit 3d5baa2 into KnpLabs:master Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants