Allow passing options from template to the MenuBuilder #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Jun 8, 2024
|
Hello, I took a second look and noticed additional locations where the options wouldn't make their way to the MenuBuilder so made more modifications and added tests to cover the modified methods. |
We were building a menu were we needed to pass some variables from our view to the knp_menu_render function. However in the builder for that menu, the $options array was always empty. With these changes the options successfully get passed through
garak
approved these changes
Jun 9, 2024
|
OK, so can you explain how the docs show passing options to your menu builder but that's not actually possible? Did we mis-understand the docs or how to do this? It seems like a bug but I don't know enough to know what should be happening. |
|
@gnat42 passing options from the template to the menu builder is possible when using the |
|
Thanks @stof much appreciated! I'll look to see if a PR for the docs are appropriate to clarify how to do this and submit if its warranted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were building a menu where we needed to pass some variables from our view to the knp_menu_render function. However in the builder for that menu, the $options array was always empty. With these changes the options successfully get passed through