Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Twig Runtime #397

Merged
merged 2 commits into from
Dec 11, 2024
Merged

add Twig Runtime #397

merged 2 commits into from
Dec 11, 2024

Conversation

garak
Copy link
Collaborator

@garak garak commented Sep 5, 2024

Fix #396 in a BC way

@garak
Copy link
Collaborator Author

garak commented Sep 5, 2024

Test failures are unrelated and due to the spaceless filter deprecation.
I opened a specific issue about it #398

@garak garak requested review from stof and alexpozzi September 5, 2024 17:23
Copy link
Member

@alexpozzi alexpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Are you gonna fix tests in this PR or in a following one?

@garak
Copy link
Collaborator Author

garak commented Dec 5, 2024

Nice, thanks!

Are you gonna fix tests in this PR or in a following one?

I've tried to fix the tests, but it seems that allowing one deprecation is not enough.
I proposed another PR about removing the use of the spaceless tag, it's still under review

@garak garak merged commit 9747837 into KnpLabs:master Dec 11, 2024
5 of 10 checks passed
@garak garak deleted the fix-twig-ext branch December 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise Twig extension
2 participants