remove deprecated spaceless #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better performance, etc. twigphp/Twig#4236
|
well, so much for a simple remove -- all the tests needs to change. So this becomes a bigger issue, one of using the whitespace control, rather than spaceless. |
ro0NL
approved these changes
Dec 4, 2024
|
i guess it's real simple to override the template in userland, but not sure if this library is longlived still. |
I quite like this library, all of my projects depend on it. I guess I should make a PR for the tests then, yes? |
|
im afraid so. But 4 months no maintenace was done, which is a bit of a red flag. |
|
#399 -.- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better performance, etc.
twigphp/Twig#4236