Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test deprecations #402

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix test deprecations #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 19 additions & 24 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
check:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -15,63 +15,56 @@ jobs:
- name: Validate composer.json
run: composer validate --strict --no-check-lock
cs-fixer:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
name: PHP-CS-Fixer
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Fix CS
uses: docker://oskarstark/php-cs-fixer-ga
twig-cs-fixer:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
name: Twig-CS-Fixer
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Require the vendor
run: composer require --dev --no-update vincentlanglet/twig-cs-fixer ^2.12
run: composer require --dev --no-update vincentlanglet/twig-cs-fixer ^3.5
- name: Update
run: composer update --no-interaction --no-progress
- name: Run
run: vendor/bin/twig-cs-fixer lint src/Knp/Menu/Resources/views
tests:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
include:
- description: 'No Symfony specified'
php: '8.1'
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
max_deprecations: 1
- description: 'No Symfony specified'
php: '8.2'
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
max_deprecations: 1
- description: 'No Symfony specified'
php: '8.3'
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
max_deprecations: 1
- description: 'No Symfony specified'
php: '8.4'
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
max_deprecations: 1
- description: 'Lowest deps'
php: '8.1'
composer_option: '--prefer-lowest'
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=0
- description: 'Symfony 5.4'
max_deprecations: 0
- description: 'Symfony 6'
php: '8.1'
symfony: 5.4.*
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
- description: 'Dev deps'
php: '8.3'
symfony: 6.4.*
max_deprecations: 1
- description: 'Symfony 7'
php: '8.4'
dev: true
symfony: 7.2.*
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=1
max_deprecations: 1
name: PHP ${{ matrix.php }} tests (${{ matrix.description }})
steps:
- name: Checkout
Expand All @@ -92,8 +85,10 @@ jobs:
if: matrix.dev
- run: composer update --no-interaction --no-progress --ansi ${{ matrix.composer_option }}
- run: vendor/bin/phpunit
env:
SYMFONY_DEPRECATIONS_HELPER: max[self]=${{matrix.max_deprecations}}
phpstan:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
name: PHPStan
steps:
- name: Checkout
Expand Down