Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed * not working on absolutePaths. Fixed files not added when using absolutePaths. #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mundusnine
Copy link
Contributor

case 1:
image

case 2:
image

@RobDangerous
Copy link
Member

This treats * just like **, doesn't it? That's not correct - ** should match multiple directories and * shouldn't. And what is that block doing that's trying to do something specifically with C-files? The matching-algo shouldn't do anything specific to particular file-types.

@mundusnine
Copy link
Contributor Author

This treats * just like **, doesn't it? That's not correct - ** should match multiple directories and * shouldn't. And what is that block doing that's trying to do something specifically with C-files? The matching-algo shouldn't do anything specific to particular file-types.

This code actually checks what folders to look in when current is undefined: https://github.com/Kode/kmake/blob/2b4b5a56a2424f0d8b402536d2282088d05445f4/kmake/src/Project.ts#L500C3-L527C4

What seems to happen is when an absolutePath is passed that ends with .c,/.h etc or * right now it doesn't take that into consideration and doesn't searchFiles in that directory. This doesn't do the same logic as ** for * it only says search in the parent directory for includes ending with * and **. Same thing for .h/.c/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants