feat(add): Avatto ME168 #8651
Merged
feat(add): Avatto ME168 #8651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreypuhovsky
force-pushed
the
feature/avatto-me168-new
branch
2 times, most recently
from
ebbf9e8 to
a8d6dd1
Compare
|
todo: add new page to the website, as the same whitelabel cannot be used again |
Koenkk
reviewed
Jan 20, 2025
src/devices/tuya.ts
Outdated
| @@ -5517,6 +5516,153 @@ const definitions: DefinitionWithExtend[] = [ | |||
| await reporting.bind(endpoint, coordinatorEndpoint, ['genOnOff']); | |||
| }, | |||
| }, | |||
| { | |||
| fingerprint: tuya.fingerprint('TS0601', ['_TZE200_ybsqljjg' /* model: 'ME168', vendor: 'AVATTO' */]), | |||
| model: 'TS0601_thermostat_5', | |||
There was a problem hiding this comment.
Since there is only 1 whitelabel, use ME168 here and remove whiteLabel
There was a problem hiding this comment.
unfortunately, I think it's not possible to use the actual model as it was white labeled somewhere else
FAIL test/index.test.js > index.js > Verify definitions
Error: Duplicate whitelabel zigbee model ME168
fingerprint: tuya.fingerprint('TS0601', ['_TZE200_ybsqljjg']),
model: 'ME168',
vendor: 'AVATTO',There was a problem hiding this comment.
named as AVATTO_ME168 for now, let's discuss this further
Koenkk
reviewed
Jan 20, 2025
Koenkk
reviewed
Jan 20, 2025
Koenkk
reviewed
Jan 20, 2025
fix for window_detection to override access type fixes for max temperature fix the all days schedule description to be more helpful
andreypuhovsky
force-pushed
the
feature/avatto-me168-new
branch
from
a8d6dd1 to
9b4969c
Compare
andreypuhovsky
force-pushed
the
feature/avatto-me168-new
branch
from
9b4969c to
8d5b2c1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my previous pull request for this device, I've purchased a Tuya Gateway to make it 99% functional :)
tuya:
Additional things: