Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cities-ets2 Road to Asia, Red Sea Map, Viva Malta, Sibir Map, Volga Map, Project Greenland #160

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

keremguvercin
Copy link
Contributor

No description provided.

@keremguvercin keremguvercin changed the title Update cities-ets2.js Update cities-ets2 Road to Asia, Red Sea Map, Viva Malta, Sibir Map, Volga Map Sep 14, 2021
@keremguvercin keremguvercin changed the title Update cities-ets2 Road to Asia, Red Sea Map, Viva Malta, Sibir Map, Volga Map Update cities-ets2 Road to Asia, Red Sea Map, Viva Malta, Sibir Map, Volga Map, Project Greenland Sep 14, 2021
@rafaelkai
Copy link
Contributor

Would you mind adding support for JRR too?

@keremguvercin
Copy link
Contributor Author

These maps are the maps that I used. I didn't use the Indonesian map. But I can use it.

@gitguardian
Copy link

gitguardian bot commented Sep 12, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret e4d436e web/stations/stations-europe.js View secret
- Generic High Entropy Secret fe945f4 web/stations/stations-europe.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Koenvh1
Copy link
Owner

Koenvh1 commented Sep 12, 2022

I have merged #161 and #171 into this, as they all depend on each other.

This is now quite the PR due to the merging of master. The main issue currently is that the logo file names are not representative of the station that uses them. Additionally I believe some stations mainly use the Arabic name (rather than the latinised version). See https://github.com/Koenvh1/ets2-local-radio/blob/master/web/stations/stations-europe.js#L2955 for an example. Personally I believe it requires some improvements before I am willing to merge it, and seeing how this has already been open for a year, I am personally not that interested in resolving the outstanding issues for this PR.

@04Marcus Could you check whether you want to use anything from this?

@AssassinLV
Copy link

AssassinLV commented Jan 8, 2024

Will this ever go in, or is this fully abandoned? (right now approaching Turkmenistan) :D
But I guess this would have been more meaningfull to be 1 PR per country - instead of 1 mega PR - as unlikely anyone will want to touch 5k+ PR...

@rafaelkai
Copy link
Contributor

rafaelkai commented Sep 22, 2024

@ModesevenTM Is there any chance that you gradually tweak and integrate this PR into local radio? I've noticed that you are updating some of the ETS2 part of the program and its weakest point is that it supports almost no modded maps (which this PR fixes).

@ModesevenTM
Copy link
Contributor

I mainly focus on station updates here and I won't be very active here anymore, mostly because of my studies and the fact that I don't play ETS2 that much now. I'm also not able to contribute here directly; only via PRs. I think though that including coverage for some more map mods would be a welcome addition and I can try to see what I can do in the future.

Map support generally needs some work to be done, since even ProMods support isn't perfect. Majority of the areas included in versions 2.60 and later are missing (for example northern Norway).

If I have some free time and willingness, I may try to include some new maps and improve coverage for the existing ones, then open 1 PR per map. As said before, one huge PR for this makes very little sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants