Update MegaFlashROM SCC+ SD Boot Behavior (Duplicate Do not Merge) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to read and restore the user MSX saved screen parameters, as is the case with the Sunrise IDE driver version 0.1.7. This allows the MegaFlashROM to boot in width 80 for example if this parameter is saved by the RTC.
Thankfully should be the last ones
|
This should thankfully close #126 |
|
Can you squash the commits into a single one using git interactive rebase? And then force-push the branch to update this pull request. Due to the indentation (alignment) changes, it is a bit hard to see what actually changed, and also whether an indentation change was accidentally left in. |
Steveneska
changed the title
Steveneska
changed the title
Steveneska
changed the title
Steveneska
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the MegaFlashROM the same boot behavior as the Sunrise IDE driver 0.1.7, that is restore the MSX saved screen parameters at boot if they've been saved by the RTC on MSX2 and higher computers.
Given that I'm currently traveling, I was only able to test and confirm it working with OpenMSX. But it shouldn't bring up any other unrelated behaviors since it's a cosmetic change at most.