add alignWithControllerVersion
to allow auto-adjustment of GW settings
#936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It's an attempt to provide a workaround for the inability to propagate values between two subcharts (
gateway
andcontroller
) inkong/ingress
chart.Branches off #935.
This is a bit explicit way, but I couldn't come up with anything else that could allow us to pick a
controller.ingressController.image
value and somehow inject it into the other subchart.Example
values.yaml
that demonstrates how this could be used in Konnect installation instructions:This should be safe, as when
gateway.deployment.kong.alignWithControllerVersion
will be left empty, the old default will be used, so we're not breaking anything. It would be opt-in and instructions would have to be updated to use that.An obvious drawback is that it won't work with just
helm install kong kong/ingress
. Installation command would have to be more complex, i.e.:So it's on a similar level of user-friendliness as just telling the user to set the router flavor explicitly if they're using KIC >= 3.0: