-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http-log): Add docs for logged header allow list #5984
feat(http-log): Add docs for logged header allow list #5984
Conversation
This PR adds the supporting documentation for PR #11427. Functional changes are to implement an allow list for which request/response headers should be included in log entries.
❌ Deploy Preview for kongdocs failed.
|
Hi @ItsKaleb , thanks for this PR. Could you please point to |
Thanks @acgoldsmith, will do that, yep. |
Hey @acgoldsmith, Vale seemed to be flagging some of the config field names as potential spelling errors. I've never used Vale before, is there a way to ignore those checks? I've also just updated the PR to address some of the legit findings it reported. |
@ItsKaleb Thanks for fixing some of those Vale errors! I'm happy to help with the others. I think maybe some extra commits were pulled in when the base branch was changed to Then I can help by getting those config names added to our Vale ignore file so Vale ignores them. |
Ah yes, thanks @cloudjumpercat |
@ItsKaleb No worries! If you'd like, I can always do the cherry pick to the new PR as well. |
Just to provide an update, I'm currently working through some hiccups with the feature branch in the main repo. Once things are sorted there, I'll revisit this PR and get the docs for the new feature fixed up. |
89349c9
to
343dffd
Compare
I've removed the Gateway 3.5 milestone the corresponding PR does not look like it will be added to the 3.5 release If I am incorrect please re-add the milestone and tag me. |
This PR adds the supporting documentation for PR #11427. Functional changes are to implement an allow list for which request/response headers should be included in log entries.
Description
Add supporting documentation for
Kong/kong#11427
Testing instructions
Netlify link:
Checklist
main
for immediate publishing, or a release branch: e.g.release/gateway-3.2
,release/deck-1.17
)