feat: enable basic runner #7835

ihexxa · 2024-08-14T08:21:17Z

Background

This PR enables basic runner by commenting out some dependencies.

Changes

Added runner, runner menu items
Integrated runner to the request pane
Updated timer to support updating step name in place
Refactored sendAction to make it can be reused

* feat: enable the test result pane * test: bring back tests and cleanups * chore: replace tabitem with tabpanel * chore: useMemo for test result counts * refactor: abstract RequestTestResultRows as a component

ihexxa · 2024-08-14T08:22:43Z

packages/insomnia/src/ui/routes/request.tsx

+  results: RequestTestResult[];
+}
+
+export const sendActionImp = async ({


The original sendAction logic are copied to this imp function although there seems lots of changes below.

This is a bit complext, I would like some explanation here on a call. I think it may be a good idea for us to hop on a call to go over all the PR. I will reserve 1-2 hrs time in my evening. Please let me know when you are available.

ihexxa · 2024-08-14T08:23:29Z

packages/insomnia/src/ui/routes/runner.tsx

+import { HelpTooltip } from '../components/help-tooltip';
+import { Icon } from '../components/icon';
+import { Pane, PaneBody, PaneHeader } from '../components/panes/pane';
+// import { RequestTestResultPane } from '../components/panes/request-test-result-pane';


Some changes are commented out to avoid introducing too many changes.

…SDK[INS-4298][INS-4299] (#7846) * Add upload CSV/JSON support for collection runner * Modify SDK to allow access and modify IterationData * Fix typos and feedbacks from PR

marckong · 2024-08-22T16:50:36Z

@ihexxa was running this locally and one thing I noticed is that when you just boot it up, and create a design doc, it restarts the app when navigating to the collection page. Please see the Loom link - https://www.loom.com/share/f6f851ca31964ff2b0bee118c28ecd63?sid=e9a9c9c3-4e18-4852-95b6-2f7c3bc84d6c

~~Steps to reproduce:~~
~~1. run Insomnia locally~~
~~2. create a design doc~~
~~3. navigate to the collection page~~

~~Expected result:~~
~~- it should be navigated to Collection page without restarting the app~~

~~Actual result:~~
~~- it restarts the app~~
~~- it stays in the Design page instead of navigating to Collection page~~

~~I wonder if this is related to this branch or not.~~

It happens in the latest dev as well

marckong

I've reviewed this PR without much context. I may need your help to unpack lots of things as the collection runner is complex scope. I suggest we hop on a call to go over each PR in order of your suggestion.

marckong · 2024-08-22T19:59:39Z

packages/insomnia/src/ui/components/dropdowns/workspace-dropdown.tsx

@@ -30,7 +30,7 @@ import { ImportModal } from '../modals/import-modal';
 import { WorkspaceDuplicateModal } from '../modals/workspace-duplicate-modal';
 import { WorkspaceSettingsModal } from '../modals/workspace-settings-modal';

-export const WorkspaceDropdown: FC = () => {
+export const WorkspaceDropdown: FC<{}> = () => {


FC has the default type for its prop, so I think P = {} is not necessary here unless we want to actually pass prop type

marckong · 2024-08-22T20:02:59Z

packages/insomnia/src/main/network/request-timing.ts

@@ -37,3 +36,19 @@ export function completeExecutionStep(requestId: string) {
        window.webContents.send(`syncTimers.${requestId}`, { executions: executions.get(requestId) });
    }
 }
+
+export function updateLatestStepName(


Would you mind explaining a bit here?

It is for updating the timing record in place (in the response pane), as originally it just allows appending records.

marckong · 2024-08-22T20:04:07Z

packages/insomnia/src/ui/routes/debug.tsx

@@ -149,7 +150,8 @@ export const loader: LoaderFunction = async ({ params }) => {
    invariant(activeWorkspaceMeta, 'Workspace meta not found');
    const activeRequestId = activeWorkspaceMeta.activeRequestId;
    const activeRequest = activeRequestId ? await models.request.getById(activeRequestId) : null;
-    if (activeRequest) {
+    const isDisplayingRunner = request.url.endsWith('/runner') || request.url.endsWith('/runner?test-end');


I like to understand more on this url pattern

It is mainly for triggering refreshing when returning from the react router action.

marckong · 2024-08-22T20:06:17Z

packages/insomnia/src/ui/routes/debug.tsx

+                  <WorkspaceDropdown />
+                </Breadcrumb>
+                <Breadcrumb className="flex text-sm truncate select-none items-center justify-self-end ml-auto mr-2.5 gap-2 text-[--color-font] h-full outline-none data-[focused]:outline-none">
+                  <Icon icon='circle-play' onClick={onRunCollection} className="cursor-pointer" />


Oh i see. It navigates to a different page

marckong · 2024-08-22T20:07:39Z

packages/insomnia/src/ui/routes/request.tsx

+  results: RequestTestResult[];
+}
+
+export const sendActionImp = async ({


This is a bit complext, I would like some explanation here on a call. I think it may be a good idea for us to hop on a call to go over all the PR. I will reserve 1-2 hrs time in my evening. Please let me know when you are available.

marckong · 2024-08-22T20:08:29Z

packages/insomnia/src/ui/routes/runner.tsx

+  const [iterationFilePath, setIterationFilePath] = useState<File | undefined>(undefined);
+
+  const [direction, setDirection] = useState<'horizontal' | 'vertical'>(settings.forceVerticalLayout ? 'vertical' : 'horizontal');
+  useEffect(() => {


Is there another way to do it without useEffect?

It is copied from another component for consistent layout behavior, probably it could be deduplicated.
And all content of sendActionImp is copied from the sendAction for reusing. I can introduce it later.

ihexxa · 2024-08-23T03:39:28Z

@marckong Let me schedule a sync at sometime.

* feat:enable serialized script execution * fix: smoke test failed * fix: app tests and vite dep optimization * chore: remove unused line * fix: some minor fixes (#7864) * fix: some minor fixes * fix: lint error

… (#7859) * check-in for more SDK expose * fix issues from comment and add unit test

jackkav · 2024-08-26T09:27:53Z

Note: abstracts the send action in order to use different exception handling.

* Fix issues from first round collection runner feedback * Match last found request with same request name rather than first found request in collection runner

* feat: add result pane for runner with iteration dividers * feat: enable runner cancellation * refactor: some minor fixes and enhancements * fix: minor fixes

filfreire · 2024-09-02T09:30:00Z

@ihexxa is this one still needed or we can close it?

ihexxa · 2024-09-02T10:07:11Z

@filfreire It is no longer needed, let me close it.

ihexxa added 8 commits August 14, 2024 15:29

feat: log request testing results and return them to the main renderer

5343a55

fix: lint error

c6111e1

fix: install chai with unified version across packages

95a1c2b

chore: restore package-lock

6458776

chore: restore package-lock

9a6d986

feat(GUI): enable test results pane (#7737)

734b64f

* feat: enable the test result pane * test: bring back tests and cleanups * chore: replace tabitem with tabpanel * chore: useMemo for test result counts * refactor: abstract RequestTestResultRows as a component

chore: cleanup package lock

3c7a123

feat: enable basic runner

b1f3d56

ihexxa self-assigned this Aug 14, 2024

ihexxa requested a review from a team August 14, 2024 08:21

ihexxa commented Aug 14, 2024

View reviewed changes

ihexxa and others added 2 commits August 15, 2024 11:25

feat: enable test result pane and test history pane

52ce664

Upload CSV/JSON file function for runner and expose IterationData in …

d3497ff

…SDK[INS-4298][INS-4299] (#7846) * Add upload CSV/JSON support for collection runner * Modify SDK to allow access and modify IterationData * Fix typos and feedbacks from PR

marckong reviewed Aug 22, 2024

View reviewed changes

ihexxa added 2 commits August 23, 2024 11:28

feat(runner): enable the console tab for the runner (#7848)

27bcfd5

fix: pick the audit fix from develop

15e8b29

ihexxa and others added 4 commits August 23, 2024 17:21

fix: executing script cancels the current running one (#7845)

21fa909

* feat:enable serialized script execution * fix: smoke test failed * fix: app tests and vite dep optimization * chore: remove unused line * fix: some minor fixes (#7864) * fix: some minor fixes * fix: lint error

fix: should not display the earliest execution history

4fff3c9

fix: set overflow behavior of uploading modal

50be3c2

Add info and execution to Insomnia SDK with collection runner[INS-4320]…

945be4d

… (#7859) * check-in for more SDK expose * fix issues from comment and add unit test

cwangsmv and others added 3 commits August 27, 2024 16:52

Collection runner upload data enhance[INS-4341] (#7875)

936b84d

* Fix issues from first round collection runner feedback * Match last found request with same request name rather than first found request in collection runner

feat: enable cancellation and introduce runner result pane (#7869)

e410ceb

* feat: add result pane for runner with iteration dividers * feat: enable runner cancellation * refactor: some minor fixes and enhancements * fix: minor fixes

fix: multiple iterations could alert

49f0b9b

ihexxa force-pushed the feat/test-result-pane branch from 3c7a123 to 359b005 Compare August 28, 2024 03:20

ihexxa closed this Sep 2, 2024

jackkav deleted the feat/runner-pr-1 branch January 29, 2025 23:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable basic runner #7835

feat: enable basic runner #7835

ihexxa commented Aug 14, 2024 •

edited

Loading

ihexxa Aug 14, 2024

marckong Aug 22, 2024

ihexxa Aug 14, 2024

marckong commented Aug 22, 2024 •

edited

Loading

marckong left a comment

marckong Aug 22, 2024

marckong Aug 22, 2024

ihexxa Aug 23, 2024

marckong Aug 22, 2024

ihexxa Aug 23, 2024

marckong Aug 22, 2024

marckong Aug 22, 2024

marckong Aug 22, 2024

ihexxa Aug 23, 2024

ihexxa commented Aug 23, 2024

jackkav commented Aug 26, 2024

filfreire commented Sep 2, 2024

ihexxa commented Sep 2, 2024

feat: enable basic runner #7835

feat: enable basic runner #7835

Conversation

ihexxa commented Aug 14, 2024 • edited Loading

Background

Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marckong commented Aug 22, 2024 • edited Loading

marckong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ihexxa commented Aug 23, 2024

jackkav commented Aug 26, 2024

filfreire commented Sep 2, 2024

ihexxa commented Sep 2, 2024

ihexxa commented Aug 14, 2024 •

edited

Loading

marckong commented Aug 22, 2024 •

edited

Loading