feat(services): add certificate support for service protocol grpcs
#11529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
85de866 to
08a1053
Compare
raoxiaoyan
changed the title
grpcsgrpcs
oowl
reviewed
Sep 11, 2023
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
08a1053 to
11cbaa3
Compare
oowl
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Sorry, I found other problem. For this change, unit test is not enough, we need write integration test for grpc upstream tls. For example https://github.com/Kong/kong/blob/master/spec/02-integration/05-proxy/18-upstream_tls_spec.lua
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
60e3165 to
9fdfbe6
Compare
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
2 times, most recently
from
d7934f3 to
83a432e
Compare
oowl
reviewed
Sep 19, 2023
| end) | ||
|
|
||
| if strategy ~= "off" then | ||
| describe("grpcs with tls", function() |
There was a problem hiding this comment.
We need to add lousy cases for this test and use the wrong ca_certificate and cert for the bad case. You'll be able to follow this to do it. https://github.com/Kong/kong/blob/master/spec/02-integration/05-proxy/18-upstream_tls_spec.lua#L350
github-actions
bot
added
the
author/community
oowl
removed
the
author/community
kikito
force-pushed
the
feat/fti-5309
branch
from
83a432e to
4674a5c
Compare
|
Move this PR target to 3.6.0.0 |
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
4674a5c to
68b4d6c
Compare
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
68b4d6c to
082e6c0
Compare
github-actions
bot
added
the
cherry-pick kong-ee
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
2 times, most recently
from
95e8af9 to
0f240d9
Compare
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
0f240d9 to
764ee31
Compare
raoxiaoyan
force-pushed
the
feat/fti-5309
branch
from
764ee31 to
0b0cbed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds certificate support for service protocol
grpcsRefs:
https://nginx.org/en/docs/http/ngx_http_grpc_module.html#grpc_ssl_verify
https://nginx.org/en/docs/http/ngx_http_grpc_module.html#grpc_ssl_certificate
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference