Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(CONTRIBUTING): mention changelog #11535

Merged
merged 5 commits into from
Oct 4, 2023
Merged

doc(CONTRIBUTING): mention changelog #11535

merged 5 commits into from
Oct 4, 2023

Conversation

fffonion
Copy link
Contributor

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@fffonion fffonion requested a review from vm-001 September 10, 2023 06:58
chronolaw
chronolaw reviewed Sep 10, 2023
View reviewed changes
chronolaw
chronolaw reviewed Sep 10, 2023
View reviewed changes
@vm-001
Copy link
Contributor

vm-001 commented Sep 11, 2023

lgtm

@github-actions github-actions bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 19, 2023
hanshuebner
hanshuebner suggested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@hanshuebner hanshuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt to the recent changelog changes.

@team-eng-enablement team-eng-enablement removed the author/community PRs from the open-source community (not Kong Inc) label Sep 26, 2023
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Sep 27, 2023
@dndx dndx requested a review from hanshuebner September 27, 2023 13:39
@hanshuebner hanshuebner merged commit 2804fe3 into master Oct 4, 2023
@hanshuebner hanshuebner deleted the fffonion-patch-1 branch October 4, 2023 14:40
@AndyZhang0707
Copy link
Collaborator

@fffonion please cherry-pick to ee. thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw left review comments

@hanshuebner hanshuebner hanshuebner approved these changes

@vm-001 vm-001 Awaiting requested review from vm-001

Assignees

@fffonion fffonion

Labels
chore Not part of the core functionality of kong, but still needed core/docs size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fffonion @vm-001 @AndyZhang0707 @hanshuebner @chronolaw @team-eng-enablement @dndx