fix(pdk): use deep copies of Route, Service, and Consumer objects when log serialize #11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objects when log serialize In the function of `kong.log.serialize`, the lifecycle of three table `ctx.route`, `ctx.service` and `ctx.authenticated_consumer` is across request. Modifying the sub-items in the current request of the table will affect the next request, resulting in unexpected behavior in Kong.
Signed-off-by: sabertobihwy <[email protected]>
chronolaw
reviewed
Sep 15, 2023
chronolaw
reviewed
Sep 15, 2023
Signed-off-by: sabertobihwy <[email protected]>
chronolaw
reviewed
Sep 18, 2023
Signed-off-by: sabertobihwy <[email protected]>
3 tasks
windmgc
pushed a commit
that referenced
this pull request
Sep 25, 2023
Reword changelog of #11566 to be more user-facing
windmgc
pushed a commit
that referenced
this pull request
Jan 24, 2024
…n log serialize (#11566) In the function of `kong.log.serialize`, the lifecycle of three table `ctx.route`, `ctx.service` and `ctx.authenticated_consumer` is across request. Modifying the sub-items in the current request of the table will affect the next request, resulting in unexpected behavior in Kong. Fix FTI-5357 --------- Signed-off-by: sabertobihwy <[email protected]>
3 tasks
windmgc
pushed a commit
that referenced
this pull request
Mar 7, 2024
…n log serialize (#11566) In the function of `kong.log.serialize`, the lifecycle of three table `ctx.route`, `ctx.service` and `ctx.authenticated_consumer` is across request. Modifying the sub-items in the current request of the table will affect the next request, resulting in unexpected behavior in Kong. Fix FTI-5357 --------- Signed-off-by: sabertobihwy <[email protected]>
windmgc
pushed a commit
that referenced
this pull request
Mar 8, 2024
…n log serialize (#11566) In the function of `kong.log.serialize`, the lifecycle of three table `ctx.route`, `ctx.service` and `ctx.authenticated_consumer` is across request. Modifying the sub-items in the current request of the table will affect the next request, resulting in unexpected behavior in Kong. Fix FTI-5357 --------- Signed-off-by: sabertobihwy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the function of
kong.log.serialize, the lifecycle of three tablectx.route,ctx.serviceandctx.authenticated_consumeris across request. Modifying the sub-items in the current request of the table will affect the next request, resulting in unexpected behavior in Kong.Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
Fix FTI-5357