-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST #11575
Closed
Closed
TEST #11575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e08c0c4)
…credentials (#9326) * fix(release): we use aws instance profiles now instead of static AWS credentials * Update .requirements Co-authored-by: Hans Hübner <[email protected]> (cherry picked from commit 6ce364a)
(cherry picked from commit 2967eb5)
Fix these two tests: * flips the target status from UNHEALTHY to HEALTHY * flips the target status from HEALTHY to UNHEALTHY (cherry picked from commit e3b1a4e)
…g incremental updates Ensure incremental router builds that are not guarded by concurrency mutexes are caught and add incremental router rebuild tests
Partially picked from kong-ee
(updated from master merge)
…ding in fast loops
…es the router to always doing full rebuild It was found that incremental rebuilding broke at some point and now the `traditional_compatible` and `expressions` router flavor always does full build instead of incremental, negating the performance benefit of incremental rebuild. Co-authored-by: Aapo Talvensaari <[email protected]> Co-authored-by: Datong Sun <[email protected]>
The steps of migration should happen in the up phase, not the teardown phase. fix FT-3293
tests(router): test for removed normalization
The traditional router would use the `a` (anchor) flag when evaluating input to ensure regex paths only match from the start of the string. Given the route path `/prefix/[0-9]+`: GET /prefix/123 => match GET /extra/prefix/123 => no match This updates the traditional_compatible router to replicate the same behavior. The underlying atc router library does not support regex flags, so we accomplish this by prepending the regex with `^`.
fixes FT-3328 Previously, when worker respawns, the `router:version` and `plugins_iterator:version` keys in the cache is incorrectly set to `init`, this causes the newly spawned worker to not rebuild the router/iterator and always use the router/iterator from when master process was created.
…9408) Co-authored-by: Hans Hübner <[email protected]>
Co-authored-by: Makito <[email protected]> Co-authored-by: Datong Sun <[email protected]> Co-authored-by: Xumin <[email protected]>
`CODEOWNERS` file was originally added in #8691. The rationale at the time was to make sure all PRs are approved and merged only after maintainers have reviewed the change. Since then, we have come a long way. PRs now are merged only after a moderator on the team has taken a look at the PR and only moderators have permission to perform a merge. This commit removes the `CODEOWNERS` file. My rationale is that the number of Kong maintainers is large and every change to every PR results in a notification to all members. This results in a very signal-to-noise ratio and a lot of members deal with a very high notification volume. My hypothesis here is that lowering the notification volume will help most members and they can deal with a smaller set of PRs on a daily basis. A select few members like myself are going to load-balance PR reviews across maintainers. This along with a lower notification volume should help us become a bit more productive and happy. After this change is merged in, you are welcome to add `CODEOWNERS` file to specific directories within the repository to ensure that the subject matter expert gets notified of changes and is requested a review. A good example of a targeted `CODEOWNERS` is a plugin or a sub-system like DAO.
This commit implements an upper limit on the number of batches that may be waiting on a queue for processing. Once the limit has been reached, the oldest batch is dropped from the queue and an error message is logged. The maximum number of batches that can be waiting on a queue is configured through the max_queued_batches parameter of the queue, which defaults to 100 and can be globally overriden with the max_queued_batches parameter in kong.conf KAG-303 This reverts commit 218cc0a.
* fix(balancer) use local target cache * fix(targets): remove dup code (cherry picked from commit 4f29d72) Co-authored-by: Vinicius Mignot <[email protected]>
We expect the upstream passive unhealthy healthcheck on HTTP status code should only mark the targets as "down" (not reachable or proxiable) using the returned HTTP status code from the target, and it should not be affected by the final HTTP status code set by Kong plugin, which is returned to the client. So we change the passive health check implementation to use nginx var `upstream_code`, this will not be changed by any plugin. FTI-4841 Fix #10281 (cherry picked from commit dbe8d94)
(cherry picked from commit 563937f)
github-actions
bot
added
core/cli
core/balancer
core/proxy
core/db/migrations
plugins/rate-limiting
core/clustering
core/templates
plugins/http-log
core/db
plugins/response-ratelimiting
core/configuration
core/docs
plugins/prometheus
chore
Not part of the core functionality of kong, but still needed
changelog
core/tracing
schema-change-noteworthy
labels
Sep 14, 2023
yesys |
test |
he |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog
chore
Not part of the core functionality of kong, but still needed
core/balancer
core/cli
core/clustering
core/configuration
core/db/migrations
core/db
core/docs
core/proxy
core/templates
core/tracing
plugins/http-log
plugins/prometheus
plugins/rate-limiting
plugins/response-ratelimiting
schema-change-noteworthy
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
CHANGELOG/unreleased/kong
or addingskip-changelog
label on PR if unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]