Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE TEST #11576

Closed
wants to merge 406 commits into from
Closed

DONT MERGE TEST #11576

wants to merge 406 commits into from

Conversation

gAmUssA
Copy link

@gAmUssA gAmUssA commented Sep 14, 2023

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

catbro666 and others added 30 commits June 26, 2023 16:20
…ration (#11091)

`parse_params` should not call `normalize_nested_params` for `application/json`. Otherwise, the key-value pair of `custom_fields_by_lua` will be converted into a nested table if the key contains dot character(s), which will cause schema violation when calling `/schemas/plugins/validate`

Fix [FTI-5070](https://konghq.atlassian.net/browse/FTI-5070)
Previously, no User clause was present.  While this still made systemd
run kong under the 'root' user id, the HOME environment variable would
not be set in the Kong process.  This caused the datafile library to
fail with various error conditions.
Include `schema-change-noteworthy` label in `kong/db/dao`.
Summary
The second param of ngx.re.gsub() is a regex pattern,
so \\ is actually \, which is an invalid regex.

Note: ngx.re.gsub() is different from string.gsub()!

This PR gives the correct regex to ngx.re.gsub().

* fix ngx.re.gsub

* style lint
…s` (#11113)

Summary
Import some changes from knyar/nginx-lua-prometheus#131.

* construct_bucket_format

* remove string.gsub

* remove ipairs

* check label_names

* ngx.re.gsub

* typo fix

* as_string
…lidation (#11124)

### Summary

On control plane there was a debug log written on every second on every worker
that had no connected clients. This will now only log it once per worker, until
number of connected clients changes.

The schema validation also had a thing called unvalidated fields that caused
huge amounts of logs to be written with large config import / validation.

Signed-off-by: Aapo Talvensaari <[email protected]>
With this patch, kong.conf settings of a DP are self-reported to the CP.
Sensitive credentials from kong.conf are redacted before they are sent
to the CP.
This patch reports the configuration, LuaCP isn't going to do
anything with it just yet. This feature is specific to Kong Inc's
Konnect offering.
for loop has better performance than function ipairs(), especially for huge table.
…goto" (#11128)

### Summary

Follow-up from #11124 to slightly clean
the code.

Signed-off-by: Aapo Talvensaari <[email protected]>
### Summary

Just changes `destory` to `destroy` in patch name.

Signed-off-by: Aapo Talvensaari <[email protected]>
add the http.route span attribute to the kong request span
adapt existing tests to pass with the new attribute
improve instrumentations tests, add checks for all spans and attributes
…1126)

Use ngx.re.match to replace string.match to get better performance.


* replace string.match

* fix mistake

* fix mistake

* use ijo option
* fix(proxy): remove kong branding in kong HTML error template

Signed-off-by: owl <[email protected]>

* fix(proxy): fix code

Signed-off-by: owl <[email protected]>

---------

Signed-off-by: owl <[email protected]>
* fix(tracing): ensure sampling rate applies to whole trace

This commit fixes a bug where the sampling rate was applied to
individual spans, so configuring values of sampling_rate < 1 would
sometimes result in split traces being reported.

The fix ensures that the sampled flag that is calculated by the sampler
for the root span is propagated to all children within the same trace.

* fix(tracing): suggestions + propagation test
Replacing uses of helpers.http_server with the new implementation of HTTP mocking, which is more stable.

Fix KAG-1148

Co-authored-by: Hans Hübner <[email protected]>
In `traditional_compatible` mode, the router would fail to work if a
route with multiple paths but no service would be created.

Fixes KAG-1961
* move to changed section

* style fix
* string.find

* ngx.get_phase

* string.len

* ngx.print

* suffix_idx + 1

* labels_start

* target_info.addresses
Move log level logic into isolated module, easy to maintain.
@gAmUssA
Copy link
Author

gAmUssA commented Sep 14, 2023

HELLO TEST TEST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment