Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugins/grpc-gateway): use string buffer to concat strings #11602

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 19, 2023

Summary

Same as #11562, use string.buffer to replace table.concat

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw force-pushed the refactor/using_string_buffer_for_grpc_gateway branch from ea96a7f to 750aec0 Compare September 19, 2023 10:32
@github-actions github-actions bot added plugins/grpc-gateway author/community PRs from the open-source community (not Kong Inc) labels Sep 19, 2023
@locao locao requested a review from brentos September 19, 2023 17:02
@windmgc windmgc merged commit b75b103 into master Sep 21, 2023
23 checks passed
@windmgc windmgc deleted the refactor/using_string_buffer_for_grpc_gateway branch September 21, 2023 07:48
@chronolaw chronolaw removed the author/community PRs from the open-source community (not Kong Inc) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants