Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(tools): simplify the implementation of tools.cjson #12316

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jan 9, 2024

Summary

Simplify the implementation of #12019.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@flrgh
Copy link
Contributor

flrgh commented Jan 11, 2024

@chronolaw does this need a cherry-pick label for EE before merging?

@chronolaw
Copy link
Contributor Author

@chronolaw does this need a cherry-pick label for EE before merging?

Yes, but this PR is a improvement of #12019, we can not cherry pick it before #12019 merge into EE.

@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 12, 2024
@windmgc windmgc merged commit 00bab18 into master Jan 15, 2024
28 checks passed
@windmgc windmgc deleted the style/simplify_tools_cjson branch January 15, 2024 01:32
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants