Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump lua-resty-aws to 1.4.1 #12846

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Apr 10, 2024

Summary

Changelog:

fix: aws configuration cannot be loaded due to pl.path cannot resolve the path started with ~ Kong/lua-resty-aws#94
fix: fix the bug of missing boolean type with a value of false in the generated request body Kong/lua-resty-aws#100
security: remove the documentation entry that contains a sample access key from AWS SDK. This avoids false postive vulnerability report. Kong/lua-resty-aws#102
feat: container credential provider now supports using auth token defined in AWS_CONTAINER_AUTHORIZATION_TOKEN and AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE. Kong/lua-resty-aws#107
fix: operations without inputs (eg, some S3 ones) would cause errors to be thrown Kong/lua-resty-aws#108

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Related FTIs:
KAG-3424
FTI-5732

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 10, 2024
@windmgc windmgc added this to the 3.7.0 milestone Apr 10, 2024
@windmgc
Copy link
Member Author

windmgc commented Apr 10, 2024

@Tieske Could you help bump a Penlight version to fix the CI problem?

@flrgh flrgh force-pushed the chore-deps-bump-resty-aws branch from d0378d1 to cfcc62e Compare April 11, 2024 16:20
@flrgh
Copy link
Contributor

flrgh commented Apr 11, 2024

Ready for merge as far as I am concerned, just waiting on 🟢 🟢 🟢 🟢 tests

@windmgc
Copy link
Member Author

windmgc commented Apr 11, 2024

@flrgh I'm waiting for a new penlight release to solve the consistent failure in CI (not sure when it will happen)
See Kong/lua-resty-aws#110 (comment)

@Tieske
Copy link
Member

Tieske commented Apr 15, 2024

Penlight release PR: lunarmodules/Penlight#472

@Tieske
Copy link
Member

Tieske commented Apr 15, 2024

New Penlight version has been released. Kongrocks PR is up as well.

@windmgc windmgc force-pushed the chore-deps-bump-resty-aws branch from cfcc62e to 3d239b1 Compare April 16, 2024 04:37
@windmgc windmgc force-pushed the chore-deps-bump-resty-aws branch from 3d239b1 to 64fdebe Compare April 19, 2024 11:07
@windmgc windmgc changed the title chore(deps): bump lua-resty-aws to 1.4.0 chore(deps): bump lua-resty-aws to 1.4.1 Apr 19, 2024
@windmgc windmgc merged commit cf650fc into master Apr 19, 2024
27 checks passed
@windmgc windmgc deleted the chore-deps-bump-resty-aws branch April 19, 2024 11:32
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12846-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12846-to-master-to-upstream
git checkout -b cherry-pick-12846-to-master-to-upstream
ancref=$(git merge-base 23878ed8b7b069aa90d1a8d12911e3ef60a77ca6 64fdebe8ba48ad678b5e00c504bab8b3c806da48)
git cherry-pick -x $ancref..64fdebe8ba48ad678b5e00c504bab8b3c806da48

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 19, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants