-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(patchs): fix kong.request.enable_buffering
PDK function cannot be used when dowstream uses HTTP/2.
#13614
fix(patchs): fix kong.request.enable_buffering
PDK function cannot be used when dowstream uses HTTP/2.
#13614
Conversation
9972720
to
9b1e3bc
Compare
9b1e3bc
to
fc3d3fb
Compare
@oowl what has been |
Ok, I see: openresty/lua-nginx-module#2243 and openresty/lua-nginx-module#2355 |
@oowl can you also check your example with SSL/TLS connection just to be sure (it is rather pointless to do h2 without SSL/TLS): |
Yeah, I will. |
626d838
to
7730d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments. I like this a lot if it works! Good work on reqwest too!
kong.request.enable_buffering
PDK function cannot be use issue when dowstream is using HTTP/2.
kong.request.enable_buffering
PDK function cannot be use issue when dowstream is using HTTP/2.kong.request.enable_buffering
PDK function cannot be used when dowstream uses HTTP/2.
Once it got 2 approved. I will squash my commit to 3 separate commits that can be merged by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
fe605b0
to
a145fb0
Compare
changelog/unreleased/kong/revert-http2-limitation-buffered-request.yml
Outdated
Show resolved
Hide resolved
a145fb0
to
3c52290
Compare
changelog/unreleased/kong/revert-http2-limitation-buffered-request.yml
Outdated
Show resolved
Hide resolved
5ec4060
to
6ec1b6a
Compare
upstream PR openresty/lua-nginx-module#2355 is merged now. Let's push forward the current PR. |
Successfully created cherry-pick PR for |
Summary
kong.request.enable_buffering
PDK function can work fine when downstream using HTTP/2, which also means all of the kong plugins including theresponse
function phase now work in HTTP2 protocol.ngx.location
subrequest API by patch bugfix: remove http2 hardcode limitation inngx.location
subrequest API openresty/lua-nginx-module#2355helpers.proxy_ssl_client
andhelpers.proxy_clien
http2 protocol support by https://github.com/oowl/lua-reqwestspec/03-plugins/38-ai-proxy/*
andspec/02-integration/05-proxy/24-buffered_spec.lua
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
AG-108
FTI-5725