update httproute validation message

Kong · Oct 9, 2023 · 35d67ad · 35d67ad
1 parent 957af79
commit 35d67ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/internal/admission/validation/gateway/httproute.go b/internal/admission/validation/gateway/httproute.go
@@ -105,7 +105,8 @@ func validateHTTPRouteFeatures(httproute *gatewayapi.HTTPRoute, parserFeatures p
 			// See: https://github.com/Kong/kubernetes-ingress-controller/issues/3679
 			if len(match.QueryParams) != 0 {
 				if !parserFeatures.ExpressionRoutes || kongVersion.LE(versions.QueryParameterVersionCutoff) {
-					return fmt.Errorf("queryparam matching is not yet supported for httproute")
+					return fmt.Errorf("queryparam matching is only supported for httproute with Kong %s and expression router",
+						versions.QueryParameterVersionCutoff.String())
 				}
 			}
 		}

diff --git a/internal/admission/validation/gateway/httproute_test.go b/internal/admission/validation/gateway/httproute_test.go
@@ -13,6 +13,7 @@ import (
 
 	"github.com/kong/kubernetes-ingress-controller/v2/internal/dataplane/parser"
 	"github.com/kong/kubernetes-ingress-controller/v2/internal/gatewayapi"
+	"github.com/kong/kubernetes-ingress-controller/v2/internal/versions"
 )
 
 func TestValidateHTTPRoute(t *testing.T) {
@@ -255,7 +256,8 @@ func TestValidateHTTPRoute(t *testing.T) {
 			}},
 			valid:         false,
 			validationMsg: "httproute spec did not pass validation",
-			err:           fmt.Errorf("queryparam matching is not yet supported for httproute"),
+			err: fmt.Errorf("queryparam matching is only supported for httproute with Kong %s and expression router",
+				versions.QueryParameterVersionCutoff),
 		},
 		{
 			msg: "we don't support any group except core kubernetes for backendRefs",